redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

USB: serial: mos7840: fix non-atomic allocation in write path

Browse source 
There is an allocation with GFP_KERNEL flag in mos7840_write(),
while it may be called from interrupt context.

Follow-up for commit 1912528376 ("USB: kobil_sct: fix non-atomic
allocation in write path")

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
This commit is contained in:
Alexey Khoroshilov 2016-08-12 01:05:09 +03:00 committed by Johan Hovold
parent 5a5a1d6142
commit 3b7c7e52ef
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/usb/serial/mos7840.c
View file

@ -1340,8 +1340,8 @@ static int mos7840_write(struct tty_struct *tty, struct usb_serial_port *port,
} }
if (urb->transfer_buffer == NULL) { if (urb->transfer_buffer == NULL) {
urb->transfer_buffer = urb->transfer_buffer = kmalloc(URB_TRANSFER_BUFFER_SIZE,
kmalloc(URB_TRANSFER_BUFFER_SIZE, GFP_KERNEL); GFP_ATOMIC);
if (!urb->transfer_buffer) if (!urb->transfer_buffer)
goto exit; goto exit;
} }