redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

spi: bcm-qspi: Fix return value check in bcm_qspi_probe() 

In case of error, the function kcalloc() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Fixes: fa236a7ef2 ("spi: bcm-qspi: Add Broadcom MSPI driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
hifive-unleashed-5.1
Wei Yongjun 2016-09-16 13:45:17 +00:00 committed by Mark Brown
parent a0319f8b12
commit 3bf3eb2b95
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/spi/spi-bcm-qspi.c
View File

@ -1174,8 +1174,8 @@ int bcm_qspi_probe(struct platform_device *pdev,
qspi->dev_ids = kcalloc(num_irqs, sizeof(struct bcm_qspi_dev_id),
GFP_KERNEL);
if (IS_ERR(qspi->dev_ids)) {
ret = PTR_ERR(qspi->dev_ids);
if (!qspi->dev_ids) {
ret = -ENOMEM;
goto qspi_probe_err;
}