redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

dmaengine: mmp-tdma: fix terminate_all return code 

In a recent cleanup, the mmp_tdma_terminate_all function was
introduced but does not set a proper return value. Almost
no slave driver uses that return value, but if one does, the
result will be undefined, which the compiler warns about:

dma/mmp_tdma.c: In function 'mmp_tdma_terminate_all':
dma/mmp_tdma.c:474:1: warning: no return statement in function returning non-void [-Wreturn-type]

This changes the driver to return zero, like most other
drivers do.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: f43a6fd400 ("dmaengine: mmp-tdma: Split device_control")
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
hifive-unleashed-5.1
Arnd Bergmann 2015-01-13 14:31:46 +01:00 committed by Vinod Koul
parent 2f56eaff20
commit 3c20ba5fb5
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/dma/mmp_tdma.c
View File

@ -471,6 +471,8 @@ static int mmp_tdma_terminate_all(struct dma_chan *chan)
mmp_tdma_disable_chan(chan);
/* disable interrupt */
mmp_tdma_enable_irq(tdmac, false);
return 0;
}
static int mmp_tdma_config(struct dma_chan *chan,