redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: r8712u: rtl871x_mlme.c: use is_zero_ether_addr() instead of memcmp()

Browse source 
Using is_zero_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is
all zeros.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2012-08-24 13:29:09 +08:00 committed by Greg Kroah-Hartman
parent efe13d868f
commit 3cd84fbd66
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/staging/rtl8712/rtl871x_mlme.c
View file

@ -28,6 +28,8 @@
#define _RTL871X_MLME_C_ #define _RTL871X_MLME_C_
#include <linux/etherdevice.h>
#include "osdep_service.h" #include "osdep_service.h"
#include "drv_types.h" #include "drv_types.h"
#include "recv_osdep.h" #include "recv_osdep.h"
@ -146,9 +148,8 @@ static struct wlan_network *_r8712_find_network(struct __queue *scanned_queue,
unsigned long irqL; unsigned long irqL;
struct list_head *phead, *plist; struct list_head *phead, *plist;
struct wlan_network *pnetwork = NULL; struct wlan_network *pnetwork = NULL;
u8 zero_addr[ETH_ALEN] = {0, 0, 0, 0, 0, 0};
if (!memcmp(zero_addr, addr, ETH_ALEN)) if (is_zero_ether_addr(addr))
return NULL; return NULL;
spin_lock_irqsave(&scanned_queue->lock, irqL); spin_lock_irqsave(&scanned_queue->lock, irqL);
phead = get_list_head(scanned_queue); phead = get_list_head(scanned_queue);