redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

net: dsa: rtl8366: Skip PVID setting if not requested 

We go to lengths to determine whether the PVID should be set
for this port or not, and then fail to take it into account.
Fix this oversight.

Fixes: d8652956cf ("net: dsa: realtek-smi: Add Realtek SMI driver")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
zero-sugar-mainline-defconfig
Linus Walleij 2020-09-19 00:29:54 +02:00 committed by David S. Miller
parent dd92f17989
commit 3dfe8dde09
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/dsa/rtl8366.c
View File

@ -436,6 +436,9 @@ void rtl8366_vlan_add(struct dsa_switch *ds, int port,
"failed to set up VLAN %04x",
vid);
if (!pvid)
continue;
ret = rtl8366_set_pvid(smi, port, vid);
if (ret)
dev_err(smi->dev,