redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

mtip32xx: uninitialized variable in mtip_quiesce_io() 

We recently introduce new continue in the loop which make gcc complain.
In theory if MTIP_FLAG_SVC_THD_ACTIVE_BIT is set, we could hit continue
over and over until eventually we time out of the loop.  In that case
"active" should be set as true, but right now it's uninitialized.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
hifive-unleashed-5.1
Dan Carpenter 2011-11-24 12:59:00 +01:00 committed by Jens Axboe
parent 60ec0eecfa
commit 3e54a3d1b8
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/block/mtip32xx/mtip32xx.c
View File

@ -1026,7 +1026,8 @@ static void mtip_issue_non_ncq_command(struct mtip_port *port, int tag)
static int mtip_quiesce_io(struct mtip_port *port, unsigned long timeout)
{
unsigned long to;
unsigned int n, active;
unsigned int n;
unsigned int active = 1;
to = jiffies + msecs_to_jiffies(timeout);
do {