redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

mmc: jz4740: fix return value check in jz4740_mmc_probe() 

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR(). Also there is already a error message within
devm_ioremap_resource(), so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Chris Ball <cjb@laptop.org>
hifive-unleashed-5.1
Wei Yongjun 2013-06-29 08:44:53 +08:00 committed by Chris Ball
parent 37c955a73d
commit 3e7e8c18a1
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/mmc/host/jz4740_mmc.c
View File

@ -783,9 +783,8 @@ static int jz4740_mmc_probe(struct platform_device* pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
host->base = devm_ioremap_resource(&pdev->dev, res);
if (!host->base) {
ret = -EBUSY;
dev_err(&pdev->dev, "Failed to ioremap base memory\n");
if (IS_ERR(host->base)) {
ret = PTR_ERR(host->base);
goto err_free_host;
}