redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

perf hists: Make hpp setup function generic

Browse source 
Now that we have the 'equal' method implemented for hpp format entries
we can ease up the logic in the following functions and make them
generic wrt comparing format entries:

  perf_hpp__setup_output_field
  perf_hpp__append_sort_keys

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1453109064-1026-8-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Jiri Olsa 2016-01-18 10:24:05 +01:00 committed by Arnaldo Carvalho de Melo
parent c0020efa07
commit 3f931f2c42
1 changed files with 8 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
tools/perf/ui/hist.c
View file

@ -551,21 +551,11 @@ void perf_hpp__setup_output_field(void)
/* append sort keys to output field */ /* append sort keys to output field */
perf_hpp__for_each_sort_list(fmt) { perf_hpp__for_each_sort_list(fmt) {
if (!list_empty(&fmt->list)) struct perf_hpp_fmt *pos;
continue;
/* perf_hpp__for_each_format(pos) {
* sort entry fields are dynamically created, if (fmt_equal(fmt, pos))
* so they can share a same sort key even though goto next;
* the list is empty.
*/
if (perf_hpp__is_sort_entry(fmt)) {
struct perf_hpp_fmt *pos;
perf_hpp__for_each_format(pos) {
if (fmt_equal(fmt, pos))
goto next;
}
} }
perf_hpp__column_register(fmt); perf_hpp__column_register(fmt);
@ -580,21 +570,11 @@ void perf_hpp__append_sort_keys(void)
/* append output fields to sort keys */ /* append output fields to sort keys */
perf_hpp__for_each_format(fmt) { perf_hpp__for_each_format(fmt) {
if (!list_empty(&fmt->sort_list)) struct perf_hpp_fmt *pos;
continue;
/* perf_hpp__for_each_sort_list(pos) {
* sort entry fields are dynamically created, if (fmt_equal(fmt, pos))
* so they can share a same sort key even though goto next;
* the list is empty.
*/
if (perf_hpp__is_sort_entry(fmt)) {
struct perf_hpp_fmt *pos;
perf_hpp__for_each_sort_list(pos) {
if (fmt_equal(fmt, pos))
goto next;
}
} }
perf_hpp__register_sort_field(fmt); perf_hpp__register_sort_field(fmt);