redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

soc/tegra: pmc: Use of_clk_get_parent_count() instead of open coding 

As of_clk_get_parent_count() returns zero on failure, while
of_count_phandle_with_args() might return a negative error code, this
also fixes the issue of possibly using a very big number in the
allocation below.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
hifive-unleashed-5.1
Geert Uytterhoeven 2018-04-18 16:50:04 +02:00 committed by Stephen Boyd
parent 54d52ad940
commit 3fd0121b02
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/soc/tegra/pmc.c
View File

@ -31,6 +31,7 @@
#include <linux/iopoll.h>
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_clk.h>
#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/pm_domain.h>
@ -725,7 +726,7 @@ static int tegra_powergate_of_get_clks(struct tegra_powergate *pg,
unsigned int i, count;
int err;
count = of_count_phandle_with_args(np, "clocks", "#clock-cells");
count = of_clk_get_parent_count(np);
if (count == 0)
return -ENODEV;