redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

irqchip/ompic: fix return value check in ompic_of_init() 

In case of error, the function ioremap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: 9b54470afd ("irqchip: add initial support for ompic")
Acked-by: Stafford Horne <shorne@gmail.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
hifive-unleashed-5.1
Wei Yongjun 2018-01-02 11:47:19 +00:00 committed by Marc Zyngier
parent b12f5d0ffc
commit 404e6bea10
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/irqchip/irq-ompic.c
View File

@ -171,9 +171,9 @@ static int __init ompic_of_init(struct device_node *node,
/* Setup the device */
ompic_base = ioremap(res.start, resource_size(&res));
if (IS_ERR(ompic_base)) {
if (!ompic_base) {
pr_err("ompic: unable to map registers");
return PTR_ERR(ompic_base);
return -ENOMEM;
}
irq = irq_of_parse_and_map(node, 0);