net: tc35815: Fix phydev supported/advertising mask
[ Upstream commit5.4-rM2-2.2.x-imx-squashed4b5b71f770
] Commit3c1bcc8614
("net: ethernet: Convert phydev advertize and supported from u32 to link mode") updated ethernet drivers to use a linkmode bitmap. It mistakenly dropped a bitwise negation in the tc35815 ethernet driver on a bitmask to set the supported/advertising flags. Found by Anthony via code inspection, not tested as I do not have the required hardware. Fixes:3c1bcc8614
("net: ethernet: Convert phydev advertize and supported from u32 to link mode") Signed-off-by: Anthony Felice <tony.felice@timesys.com> Reviewed-by: Akshay Bhat <akshay.bhat@timesys.com> Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
parent
7bbf73e918
commit
4124b1317f
|
@ -644,7 +644,7 @@ static int tc_mii_probe(struct net_device *dev)
|
|||
linkmode_set_bit(ETHTOOL_LINK_MODE_10baseT_Half_BIT, mask);
|
||||
linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Half_BIT, mask);
|
||||
}
|
||||
linkmode_and(phydev->supported, phydev->supported, mask);
|
||||
linkmode_andnot(phydev->supported, phydev->supported, mask);
|
||||
linkmode_copy(phydev->advertising, phydev->supported);
|
||||
|
||||
lp->link = 0;
|
||||
|
|
Loading…
Reference in New Issue