redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

regulator: tps65218: Remove unnecessary regulator_unregister call 

Current code uses devm_regulator_register() so the we don't need to explicitly
call regulator_unregister() in .remove.
And then we don't need to save rdev pointer to tps->rdev[id].

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Keerthy <j-keerthy@ti.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
hifive-unleashed-5.1
Axel Lin 2014-02-19 16:34:11 +08:00 committed by Mark Brown
parent c46b5295ac
commit 413be59e2f
1 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/regulator/tps65218-regulator.c
View File

@ -267,23 +267,6 @@ static int tps65218_regulator_probe(struct platform_device *pdev)
return PTR_ERR(rdev);
}
/* Save regulator */
tps->rdev[id] = rdev;
return 0;
}
static int tps65218_regulator_remove(struct platform_device *pdev)
{
struct tps65218 *tps = platform_get_drvdata(pdev);
const struct of_device_id *match;
const struct tps_info *template;
match = of_match_device(tps65218_of_match, &pdev->dev);
template = match->data;
regulator_unregister(tps->rdev[template->id]);
platform_set_drvdata(pdev, NULL);
return 0;
}
@ -294,7 +277,6 @@ static struct platform_driver tps65218_regulator_driver = {
.of_match_table = of_match_ptr(tps65218_of_match),
},
.probe = tps65218_regulator_probe,
.remove = tps65218_regulator_remove,
};
module_platform_driver(tps65218_regulator_driver);