redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

gpio: pxa: checking IS_ERR() instead of NULL 

irq_domain_add_legacy() returns NULL on error, it doesn't return error
pointers.

Fixes: 384ca3c6a2 ('gpio: pxa: change the interrupt management')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
hifive-unleashed-5.1
Dan Carpenter 2016-01-05 12:56:37 +03:00 committed by Linus Walleij
parent 4b63739efa
commit 41d107ad92
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpio/gpio-pxa.c
View File

@ -646,8 +646,8 @@ static int pxa_gpio_probe(struct platform_device *pdev)
pchip->irqdomain = irq_domain_add_legacy(pdev->dev.of_node,
pxa_last_gpio + 1, irq_base,
0, &pxa_irq_domain_ops, pchip);
if (IS_ERR(pchip->irqdomain))
return PTR_ERR(pchip->irqdomain);
if (!pchip->irqdomain)
return -ENOMEM;
irq0 = platform_get_irq_byname(pdev, "gpio0");
irq1 = platform_get_irq_byname(pdev, "gpio1");