rt2x00: Fix transfer speed regression for USB hardware
Patch:
rt2x00: Make rt2x00_queue_entry_for_each more flexible
commit: 10e11568ca
introduced a severe regression on the throughput
for USB hardware. It turns out that the exiting of
the rt2x00queue_for_each_entry() was done too early.
The exact cause for this regression is unknown,
but by disabling the premature exiting of the loop
seems to resolve the issue.
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Reported-by: Yasushi SHOJI <yashi@atmark-techno.com>
Reported-by: Balint Viragh <bviragh@dension.com>
Tested-by: Balint Viragh <bviragh@dension.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
parent
aca355b978
commit
4268d8ed64
|
@ -298,7 +298,7 @@ static bool rt2x00usb_kick_tx_entry(struct queue_entry *entry, void* data)
|
||||||
|
|
||||||
if (!test_and_clear_bit(ENTRY_DATA_PENDING, &entry->flags) ||
|
if (!test_and_clear_bit(ENTRY_DATA_PENDING, &entry->flags) ||
|
||||||
test_bit(ENTRY_DATA_STATUS_PENDING, &entry->flags))
|
test_bit(ENTRY_DATA_STATUS_PENDING, &entry->flags))
|
||||||
return true;
|
return false;
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* USB devices cannot blindly pass the skb->len as the
|
* USB devices cannot blindly pass the skb->len as the
|
||||||
|
@ -392,7 +392,7 @@ static bool rt2x00usb_kick_rx_entry(struct queue_entry *entry, void* data)
|
||||||
|
|
||||||
if (test_and_set_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags) ||
|
if (test_and_set_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags) ||
|
||||||
test_bit(ENTRY_DATA_STATUS_PENDING, &entry->flags))
|
test_bit(ENTRY_DATA_STATUS_PENDING, &entry->flags))
|
||||||
return true;
|
return false;
|
||||||
|
|
||||||
rt2x00lib_dmastart(entry);
|
rt2x00lib_dmastart(entry);
|
||||||
|
|
||||||
|
@ -447,7 +447,7 @@ static bool rt2x00usb_flush_entry(struct queue_entry *entry, void* data)
|
||||||
struct queue_entry_priv_usb_bcn *bcn_priv = entry->priv_data;
|
struct queue_entry_priv_usb_bcn *bcn_priv = entry->priv_data;
|
||||||
|
|
||||||
if (!test_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags))
|
if (!test_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags))
|
||||||
return true;
|
return false;
|
||||||
|
|
||||||
usb_kill_urb(entry_priv->urb);
|
usb_kill_urb(entry_priv->urb);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue