media: pxa_camera: Fix check for pdev->dev.of_node
Clang warns that the address of a pointer will always evaluated as true in a boolean context. drivers/media/platform/pxa_camera.c:2400:17: warning: address of 'pdev->dev.of_node' will always evaluate to 'true' [-Wpointer-bool-conversion] if (&pdev->dev.of_node && !pcdev->pdata) { ~~~~~~~~~~^~~~~~~ ~~ 1 warning generated. Judging from the rest of the kernel, it seems like this was an error and just the value of of_node should be checked rather than the address. Reported-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
parent
ab8ff650e5
commit
44d7f1a77d
|
@ -2397,7 +2397,7 @@ static int pxa_camera_probe(struct platform_device *pdev)
|
|||
pcdev->res = res;
|
||||
|
||||
pcdev->pdata = pdev->dev.platform_data;
|
||||
if (&pdev->dev.of_node && !pcdev->pdata) {
|
||||
if (pdev->dev.of_node && !pcdev->pdata) {
|
||||
err = pxa_camera_pdata_from_dt(&pdev->dev, pcdev, &pcdev->asd);
|
||||
} else {
|
||||
pcdev->platform_flags = pcdev->pdata->flags;
|
||||
|
|
Loading…
Reference in a new issue