redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

drivers:staging:silicom Fixed extern warnings reported by checkpatch

Browse source 
1) Deleted  bp_proc_create() declaration from bp_mod.h,
because it is declared as static in bpctl_mod.c and not used anywhere.

2) checkpatch warns about
     WARNING: externs should be avoided in .c files

because we have function declarations in bptcl_mod.c,These
functions are not used anywhere else so made them static.

Signed-off-by: Surendra Patil <surendra.tux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Surendra Patil 2014-02-11 23:57:22 -08:00 committed by Greg Kroah-Hartman
parent 74c0da19c4
commit 4624b5433f
2 changed files with 10 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/staging/silicom/bp_mod.h
View file

@ -698,5 +698,3 @@ static inline unsigned int jiffies_to_msecs(const unsigned long j)
readl((void *)((a)->mem_map) + BP10GB_##reg)) readl((void *)((a)->mem_map) + BP10GB_##reg))
#endif #endif
int bp_proc_create(void);

20
drivers/staging/silicom/bpctl_mod.c
View file

@ -117,12 +117,12 @@ static int wdt_timer(struct bpctl_dev *pbpctl_dev, int *time_left);
static struct bpctl_dev *get_status_port_fn(struct bpctl_dev *pbpctl_dev); static struct bpctl_dev *get_status_port_fn(struct bpctl_dev *pbpctl_dev);
static void if_scan_init(void); static void if_scan_init(void);
int bypass_proc_create_dev_sd(struct bpctl_dev *pbp_device_block); static int bypass_proc_create_dev_sd(struct bpctl_dev *pbp_device_block);
int bypass_proc_remove_dev_sd(struct bpctl_dev *pbp_device_block); static int bypass_proc_remove_dev_sd(struct bpctl_dev *pbp_device_block);
int bp_proc_create(void); static int bp_proc_create(void);
int is_bypass_fn(struct bpctl_dev *pbpctl_dev); static int is_bypass_fn(struct bpctl_dev *pbpctl_dev);
int get_dev_idx_bsf(int bus, int slot, int func); static int get_dev_idx_bsf(int bus, int slot, int func);
static int bp_get_dev_idx_bsf(struct net_device *dev, int *index) static int bp_get_dev_idx_bsf(struct net_device *dev, int *index)
{ {
@ -262,7 +262,7 @@ static struct notifier_block bp_notifier_block = {
.notifier_call = bp_device_event, .notifier_call = bp_device_event,
}; };
int is_bypass_fn(struct bpctl_dev *pbpctl_dev); static int is_bypass_fn(struct bpctl_dev *pbpctl_dev);
int wdt_time_left(struct bpctl_dev *pbpctl_dev); int wdt_time_left(struct bpctl_dev *pbpctl_dev);
static void write_pulse(struct bpctl_dev *pbpctl_dev, static void write_pulse(struct bpctl_dev *pbpctl_dev,
@ -4906,7 +4906,7 @@ static int get_bypass_info_fn(struct bpctl_dev *pbpctl_dev, char *dev_name,
return 0; return 0;
} }
int get_dev_idx_bsf(int bus, int slot, int func) static int get_dev_idx_bsf(int bus, int slot, int func)
{ {
int idx_dev = 0; int idx_dev = 0;
for (idx_dev = 0; for (idx_dev = 0;
@ -6786,7 +6786,7 @@ EXPORT_SYMBOL(bp_if_scan_sd);
static struct proc_dir_entry *bp_procfs_dir; static struct proc_dir_entry *bp_procfs_dir;
int bp_proc_create(void) static int bp_proc_create(void)
{ {
bp_procfs_dir = proc_mkdir(BP_PROC_DIR, init_net.proc_net); bp_procfs_dir = proc_mkdir(BP_PROC_DIR, init_net.proc_net);
if (bp_procfs_dir == (struct proc_dir_entry *)0) { if (bp_procfs_dir == (struct proc_dir_entry *)0) {
@ -7414,7 +7414,7 @@ static int show_wd_autoreset(struct seq_file *m, void *v)
} }
RW_FOPS(wd_autoreset) RW_FOPS(wd_autoreset)
int bypass_proc_create_dev_sd(struct bpctl_dev *pbp_device_block) static int bypass_proc_create_dev_sd(struct bpctl_dev *pbp_device_block)
{ {
struct bypass_pfs_sd *current_pfs = &(pbp_device_block->bypass_pfs_set); struct bypass_pfs_sd *current_pfs = &(pbp_device_block->bypass_pfs_set);
static struct proc_dir_entry *procfs_dir; static struct proc_dir_entry *procfs_dir;
@ -7484,7 +7484,7 @@ int bypass_proc_create_dev_sd(struct bpctl_dev *pbp_device_block)
return ret; return ret;
} }
int bypass_proc_remove_dev_sd(struct bpctl_dev *pbp_device_block) static int bypass_proc_remove_dev_sd(struct bpctl_dev *pbp_device_block)
{ {
struct bypass_pfs_sd *current_pfs = &pbp_device_block->bypass_pfs_set; struct bypass_pfs_sd *current_pfs = &pbp_device_block->bypass_pfs_set;