redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

i2c: designware: Drop unneeded condition in i2c_dw_validate_speed() 

We may bailout directly from the loop instead of breaking it and
testing a loop counter. This also gives advantages such as decreased
indentation level along with dropped unneeded condition.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
alistair/sunxi64-5.8
Andy Shevchenko 2020-05-19 15:50:40 +03:00 committed by Wolfram Sang
parent 20ee1d9020
commit 462cfcb4aa
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/i2c/busses/i2c-designware-common.c
View File

@ -127,16 +127,14 @@ int i2c_dw_validate_speed(struct dw_i2c_dev *dev)
*/
for (i = 0; i < ARRAY_SIZE(i2c_dw_supported_speeds); i++) {
if (t->bus_freq_hz == i2c_dw_supported_speeds[i])
break;
}
if (i == ARRAY_SIZE(i2c_dw_supported_speeds)) {
dev_err(dev->dev,
"%d Hz is unsupported, only 100kHz, 400kHz, 1MHz and 3.4MHz are supported\n",
t->bus_freq_hz);
return -EINVAL;
return 0;
}
return 0;
dev_err(dev->dev,
"%d Hz is unsupported, only 100kHz, 400kHz, 1MHz and 3.4MHz are supported\n",
t->bus_freq_hz);
return -EINVAL;
}
EXPORT_SYMBOL_GPL(i2c_dw_validate_speed);