drivers/rtc/rtc-ds1305.c: add missing braces around sizeof
Silences the following type of warnings: WARNING: sizeof buf should be sizeof(buf) Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Cc: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>hifive-unleashed-5.1
parent
48c48180de
commit
465008fa46
|
@ -158,7 +158,7 @@ static int ds1305_alarm_irq_enable(struct device *dev, unsigned int enabled)
|
||||||
goto done;
|
goto done;
|
||||||
buf[1] &= ~DS1305_AEI0;
|
buf[1] &= ~DS1305_AEI0;
|
||||||
}
|
}
|
||||||
err = spi_write_then_read(ds1305->spi, buf, sizeof buf, NULL, 0);
|
err = spi_write_then_read(ds1305->spi, buf, sizeof(buf), NULL, 0);
|
||||||
if (err >= 0)
|
if (err >= 0)
|
||||||
ds1305->ctrl[0] = buf[1];
|
ds1305->ctrl[0] = buf[1];
|
||||||
done:
|
done:
|
||||||
|
@ -181,8 +181,8 @@ static int ds1305_get_time(struct device *dev, struct rtc_time *time)
|
||||||
/* Use write-then-read to get all the date/time registers
|
/* Use write-then-read to get all the date/time registers
|
||||||
* since dma from stack is nonportable
|
* since dma from stack is nonportable
|
||||||
*/
|
*/
|
||||||
status = spi_write_then_read(ds1305->spi, &addr, sizeof addr,
|
status = spi_write_then_read(ds1305->spi, &addr, sizeof(addr),
|
||||||
buf, sizeof buf);
|
buf, sizeof(buf));
|
||||||
if (status < 0)
|
if (status < 0)
|
||||||
return status;
|
return status;
|
||||||
|
|
||||||
|
@ -237,7 +237,7 @@ static int ds1305_set_time(struct device *dev, struct rtc_time *time)
|
||||||
buf[4], buf[5], buf[6], buf[7]);
|
buf[4], buf[5], buf[6], buf[7]);
|
||||||
|
|
||||||
/* use write-then-read since dma from stack is nonportable */
|
/* use write-then-read since dma from stack is nonportable */
|
||||||
return spi_write_then_read(ds1305->spi, buf, sizeof buf,
|
return spi_write_then_read(ds1305->spi, buf, sizeof(buf),
|
||||||
NULL, 0);
|
NULL, 0);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -286,8 +286,8 @@ static int ds1305_get_alarm(struct device *dev, struct rtc_wkalrm *alm)
|
||||||
* of EFI status is at best fragile anyway (given IRQ handlers).
|
* of EFI status is at best fragile anyway (given IRQ handlers).
|
||||||
*/
|
*/
|
||||||
addr = DS1305_CONTROL;
|
addr = DS1305_CONTROL;
|
||||||
status = spi_write_then_read(spi, &addr, sizeof addr,
|
status = spi_write_then_read(spi, &addr, sizeof(addr),
|
||||||
ds1305->ctrl, sizeof ds1305->ctrl);
|
ds1305->ctrl, sizeof(ds1305->ctrl));
|
||||||
if (status < 0)
|
if (status < 0)
|
||||||
return status;
|
return status;
|
||||||
|
|
||||||
|
@ -296,8 +296,8 @@ static int ds1305_get_alarm(struct device *dev, struct rtc_wkalrm *alm)
|
||||||
|
|
||||||
/* get and check ALM0 registers */
|
/* get and check ALM0 registers */
|
||||||
addr = DS1305_ALM0(DS1305_SEC);
|
addr = DS1305_ALM0(DS1305_SEC);
|
||||||
status = spi_write_then_read(spi, &addr, sizeof addr,
|
status = spi_write_then_read(spi, &addr, sizeof(addr),
|
||||||
buf, sizeof buf);
|
buf, sizeof(buf));
|
||||||
if (status < 0)
|
if (status < 0)
|
||||||
return status;
|
return status;
|
||||||
|
|
||||||
|
@ -381,7 +381,7 @@ static int ds1305_set_alarm(struct device *dev, struct rtc_wkalrm *alm)
|
||||||
"alm0 write", buf[1 + DS1305_SEC], buf[1 + DS1305_MIN],
|
"alm0 write", buf[1 + DS1305_SEC], buf[1 + DS1305_MIN],
|
||||||
buf[1 + DS1305_HOUR], buf[1 + DS1305_WDAY]);
|
buf[1 + DS1305_HOUR], buf[1 + DS1305_WDAY]);
|
||||||
|
|
||||||
status = spi_write_then_read(spi, buf, sizeof buf, NULL, 0);
|
status = spi_write_then_read(spi, buf, sizeof(buf), NULL, 0);
|
||||||
if (status < 0)
|
if (status < 0)
|
||||||
return status;
|
return status;
|
||||||
|
|
||||||
|
@ -474,7 +474,7 @@ static void ds1305_work(struct work_struct *work)
|
||||||
buf[1] = ds1305->ctrl[0];
|
buf[1] = ds1305->ctrl[0];
|
||||||
buf[2] = 0;
|
buf[2] = 0;
|
||||||
|
|
||||||
status = spi_write_then_read(spi, buf, sizeof buf,
|
status = spi_write_then_read(spi, buf, sizeof(buf),
|
||||||
NULL, 0);
|
NULL, 0);
|
||||||
if (status < 0)
|
if (status < 0)
|
||||||
dev_dbg(&spi->dev, "clear irq --> %d\n", status);
|
dev_dbg(&spi->dev, "clear irq --> %d\n", status);
|
||||||
|
@ -627,8 +627,8 @@ static int ds1305_probe(struct spi_device *spi)
|
||||||
|
|
||||||
/* read and cache control registers */
|
/* read and cache control registers */
|
||||||
addr = DS1305_CONTROL;
|
addr = DS1305_CONTROL;
|
||||||
status = spi_write_then_read(spi, &addr, sizeof addr,
|
status = spi_write_then_read(spi, &addr, sizeof(addr),
|
||||||
ds1305->ctrl, sizeof ds1305->ctrl);
|
ds1305->ctrl, sizeof(ds1305->ctrl));
|
||||||
if (status < 0) {
|
if (status < 0) {
|
||||||
dev_dbg(&spi->dev, "can't %s, %d\n",
|
dev_dbg(&spi->dev, "can't %s, %d\n",
|
||||||
"read", status);
|
"read", status);
|
||||||
|
@ -659,7 +659,7 @@ static int ds1305_probe(struct spi_device *spi)
|
||||||
|
|
||||||
buf[0] = DS1305_WRITE | DS1305_CONTROL;
|
buf[0] = DS1305_WRITE | DS1305_CONTROL;
|
||||||
buf[1] = ds1305->ctrl[0];
|
buf[1] = ds1305->ctrl[0];
|
||||||
status = spi_write_then_read(spi, buf, sizeof buf, NULL, 0);
|
status = spi_write_then_read(spi, buf, sizeof(buf), NULL, 0);
|
||||||
|
|
||||||
dev_dbg(&spi->dev, "clear WP --> %d\n", status);
|
dev_dbg(&spi->dev, "clear WP --> %d\n", status);
|
||||||
if (status < 0)
|
if (status < 0)
|
||||||
|
@ -713,7 +713,7 @@ static int ds1305_probe(struct spi_device *spi)
|
||||||
buf[1] = ds1305->ctrl[0];
|
buf[1] = ds1305->ctrl[0];
|
||||||
buf[2] = ds1305->ctrl[1];
|
buf[2] = ds1305->ctrl[1];
|
||||||
buf[3] = ds1305->ctrl[2];
|
buf[3] = ds1305->ctrl[2];
|
||||||
status = spi_write_then_read(spi, buf, sizeof buf, NULL, 0);
|
status = spi_write_then_read(spi, buf, sizeof(buf), NULL, 0);
|
||||||
if (status < 0) {
|
if (status < 0) {
|
||||||
dev_dbg(&spi->dev, "can't %s, %d\n",
|
dev_dbg(&spi->dev, "can't %s, %d\n",
|
||||||
"write", status);
|
"write", status);
|
||||||
|
@ -725,8 +725,8 @@ static int ds1305_probe(struct spi_device *spi)
|
||||||
|
|
||||||
/* see if non-Linux software set up AM/PM mode */
|
/* see if non-Linux software set up AM/PM mode */
|
||||||
addr = DS1305_HOUR;
|
addr = DS1305_HOUR;
|
||||||
status = spi_write_then_read(spi, &addr, sizeof addr,
|
status = spi_write_then_read(spi, &addr, sizeof(addr),
|
||||||
&value, sizeof value);
|
&value, sizeof(value));
|
||||||
if (status < 0) {
|
if (status < 0) {
|
||||||
dev_dbg(&spi->dev, "read HOUR --> %d\n", status);
|
dev_dbg(&spi->dev, "read HOUR --> %d\n", status);
|
||||||
return status;
|
return status;
|
||||||
|
|
Loading…
Reference in New Issue