redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

ACPICA: Conditionally perform complex per-predefined-name repairs

Browse source 
Only attempt the "complex" repairs (package sorting, buffer
expansion) if the previous "generic" validation and repair was
successful.

Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
This commit is contained in:
Bob Moore 2009-12-11 15:26:13 +08:00 committed by Len Brown
parent 43420bbb89
commit 465da9eb75
1 changed files with 24 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
drivers/acpi/acpica/nspredef.c
View file

@ -215,31 +215,42 @@ acpi_ns_check_predefined_names(struct acpi_namespace_node *node,
data->node_flags = node->flags; data->node_flags = node->flags;
data->pathname = pathname; data->pathname = pathname;
/* TBD: For variable-length Packages, remove NULL elements here */
/* /*
* Check that the type of the return object is what is expected for * Check that the type of the main return object is what is expected
* this predefined name * for this predefined name
*/ */
status = acpi_ns_check_object_type(data, return_object_ptr, status = acpi_ns_check_object_type(data, return_object_ptr,
predefined->info.expected_btypes, predefined->info.expected_btypes,
ACPI_NOT_PACKAGE_ELEMENT); ACPI_NOT_PACKAGE_ELEMENT);
if (ACPI_SUCCESS(status)) { if (ACPI_FAILURE(status)) {
/* goto exit;
* For returned Package objects, check the type of all sub-objects. }
* Note: Package may have been created by call above.
*/ /*
if ((*return_object_ptr)->common.type == ACPI_TYPE_PACKAGE) { * For returned Package objects, check the type of all sub-objects.
status = acpi_ns_check_package(data, return_object_ptr); * Note: Package may have been newly created by call above.
*/
if ((*return_object_ptr)->common.type == ACPI_TYPE_PACKAGE) {
/* TBD: For variable-length Packages, remove NULL elements here */
status = acpi_ns_check_package(data, return_object_ptr);
if (ACPI_FAILURE(status)) {
goto exit;
} }
} }
/* /*
* Perform additional, more complicated repairs on a per-name * The return object was OK, or it was successfully repaired above.
* basis. Do this regardless of the status from above. * Now make some additional checks such as verifying that package
* objects are sorted correctly (if required) or buffer objects have
* the correct data width (bytes vs. dwords). These repairs are
* performed on a per-name basis, i.e., the code is specific to
* particular predefined names.
*/ */
status = acpi_ns_complex_repairs(data, node, status, return_object_ptr); status = acpi_ns_complex_repairs(data, node, status, return_object_ptr);
exit:
/* /*
* If the object validation failed or if we successfully repaired one * If the object validation failed or if we successfully repaired one
* or more objects, mark the parent node to suppress further warning * or more objects, mark the parent node to suppress further warning