redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

platform/x86: ideapad-laptop: hide unused 'touchpad_store'

Browse source 
A readonly sysfs property must not have a 'store' function:

drivers/platform/x86/ideapad-laptop.c:438:16: error: 'touchpad_store' defined but not used [-Werror=unused-function]

We can either comment it out or remove the function entirely,
without a good reason one or or another I picked the second option.

Fixes: 7f36314599 ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
This commit is contained in:
Arnd Bergmann 2017-05-22 15:07:03 +02:00 committed by Andy Shevchenko
parent 23ccd0363c
commit 46936fd65c
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/platform/x86/ideapad-laptop.c
View file

@ -435,9 +435,10 @@ static ssize_t touchpad_show(struct device *dev,
return sprintf(buf, "%lu\n", result);
}
static ssize_t touchpad_store(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t count)
/* Switch to RO for now: It might be revisited in the future */
static ssize_t __maybe_unused touchpad_store(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t count)
{
struct ideapad_private *priv = dev_get_drvdata(dev);
bool state;
@ -453,7 +454,6 @@ static ssize_t touchpad_store(struct device *dev,
return count;
}
/* Switch to RO for now: It might be revisited in the future */
static DEVICE_ATTR_RO(touchpad);
static struct attribute *ideapad_attributes[] = {