redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

spmi: pmic-arb: check apid enabled before calling the handler 

The driver currently invokes the apid handler (periph_handler())
once it sees that the summary status bit for that apid is set.

However the hardware is designed to set that bit even if the apid
interrupts are disabled. The driver should check whether the apid
is indeed enabled before calling the apid handler.

Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Abhijeet Dharmapurikar 2017-05-10 19:55:39 +05:30 committed by Greg Kroah-Hartman
parent 5f9b2ea3da
commit 472eaf8bed
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/spmi/spmi-pmic-arb.c
View File

@ -536,8 +536,8 @@ static void pmic_arb_chained_irq(struct irq_desc *desc)
void __iomem *intr = pa->intr;
int first = pa->min_apid >> 5;
int last = pa->max_apid >> 5;
u32 status;
int i, id;
u32 status, enable;
int i, id, apid;
chained_irq_enter(chip, desc);
@ -547,7 +547,11 @@ static void pmic_arb_chained_irq(struct irq_desc *desc)
while (status) {
id = ffs(status) - 1;
status &= ~BIT(id);
periph_interrupt(pa, id + i * 32);
apid = id + i * 32;
enable = readl_relaxed(intr +
pa->ver_ops->acc_enable(apid));
if (enable & SPMI_PIC_ACC_ENABLE_BIT)
periph_interrupt(pa, apid);
}
}