redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

V4L/DVB: videobuf-dma-sg: Avoid using a wrong size

Browse source 
drivers/media/video/videobuf-dma-sg.c: In function ‘__videobuf_mmap_mapper’:
drivers/media/video/videobuf-dma-sg.c:557: warning: ‘size’ may be used uninitialized in this function

The condition where size is floating should never happen, due to the paranoia check,
but a future change at the logic might break it. So, let's just set size to zero and
use it for the paranoia check.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Mauro Carvalho Chehab 2010-04-25 11:23:52 -03:00
parent e4dac289f0
commit 474675ad80
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/media/video/videobuf-dma-sg.c
View file

@ -554,7 +554,7 @@ static int __videobuf_mmap_mapper(struct videobuf_queue *q,
{
struct videobuf_dma_sg_memory *mem = buf->priv;
struct videobuf_mapping *map;
unsigned int first, last, size, i;
unsigned int first, last, size = 0, i;
int retval;
retval = -EINVAL;
@ -579,7 +579,7 @@ static int __videobuf_mmap_mapper(struct videobuf_queue *q,
}
/* paranoia, should never happen since buf is always valid. */
if (VIDEO_MAX_FRAME == first) {
if (!size) {
dprintk(1, "mmap app bug: offset invalid [offset=0x%lx]\n",
(vma->vm_pgoff << PAGE_SHIFT));
goto done;