redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

devlink: use -ENOSPC to indicate no more room for snapshots

Browse source 
The devlink_region_snapshot_create function returns -ENOMEM when the
maximum number of snapshots has been reached. This is confusing because
it is not an issue of being out of memory. Change this to use -ENOSPC
instead.

Reported-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jacob Keller 2020-03-26 11:37:12 -07:00 committed by David S. Miller
parent cf80faee79
commit 47a39f6105
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
net/core/devlink.c
View file

@ -3793,7 +3793,7 @@ __devlink_region_snapshot_create(struct devlink_region *region,
/* check if region can hold one more snapshot */
if (region->cur_snapshots == region->max_snapshots)
return -ENOMEM;
return -ENOSPC;
if (devlink_region_snapshot_get_by_id(region, snapshot_id))
return -EEXIST;