ipv6: addrconf: do not block BH in ipv6_chk_addr_and_flags()
rcu_read_lock() is enough here, as inet6_ifa_finish_destroy() uses kfree_rcu() Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
3f27fb2321
commit
480318a0a4
|
@ -1844,7 +1844,7 @@ int ipv6_chk_addr_and_flags(struct net *net, const struct in6_addr *addr,
|
||||||
struct inet6_ifaddr *ifp;
|
struct inet6_ifaddr *ifp;
|
||||||
u32 ifp_flags;
|
u32 ifp_flags;
|
||||||
|
|
||||||
rcu_read_lock_bh();
|
rcu_read_lock();
|
||||||
hlist_for_each_entry_rcu(ifp, &inet6_addr_lst[hash], addr_lst) {
|
hlist_for_each_entry_rcu(ifp, &inet6_addr_lst[hash], addr_lst) {
|
||||||
if (!net_eq(dev_net(ifp->idev->dev), net))
|
if (!net_eq(dev_net(ifp->idev->dev), net))
|
||||||
continue;
|
continue;
|
||||||
|
@ -1858,12 +1858,12 @@ int ipv6_chk_addr_and_flags(struct net *net, const struct in6_addr *addr,
|
||||||
!(ifp_flags&banned_flags) &&
|
!(ifp_flags&banned_flags) &&
|
||||||
(!dev || ifp->idev->dev == dev ||
|
(!dev || ifp->idev->dev == dev ||
|
||||||
!(ifp->scope&(IFA_LINK|IFA_HOST) || strict))) {
|
!(ifp->scope&(IFA_LINK|IFA_HOST) || strict))) {
|
||||||
rcu_read_unlock_bh();
|
rcu_read_unlock();
|
||||||
return 1;
|
return 1;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
rcu_read_unlock_bh();
|
rcu_read_unlock();
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
EXPORT_SYMBOL(ipv6_chk_addr_and_flags);
|
EXPORT_SYMBOL(ipv6_chk_addr_and_flags);
|
||||||
|
|
Loading…
Reference in a new issue