redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

greybus: bundle: fix sleep-while-atomic in gb_bundle_destroy

Browse source 
Make sure to release the spin lock protecting the interface bundle lists
before tearing down the connections and removing the bundle device,
which are operations that may sleep.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
This commit is contained in:
Johan Hovold 2015-02-13 11:28:09 +08:00 committed by Greg Kroah-Hartman
parent 067f3b6bfa
commit 48d7077c00
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/staging/greybus/bundle.c
View file

@ -126,6 +126,7 @@ struct gb_bundle *gb_bundle_create(struct gb_interface *intf, u8 interface_id)
*/
void gb_bundle_destroy(struct gb_interface *intf)
{
LIST_HEAD(list);
struct gb_bundle *bundle;
struct gb_bundle *temp;
@ -133,12 +134,14 @@ void gb_bundle_destroy(struct gb_interface *intf)
return;
spin_lock_irq(&gb_bundles_lock);
list_for_each_entry_safe(bundle, temp, &intf->bundles, links) {
list_splice_init(&intf->bundles, &list);
spin_unlock_irq(&gb_bundles_lock);
list_for_each_entry_safe(bundle, temp, &list, links) {
list_del(&bundle->links);
gb_bundle_connections_exit(bundle);
device_del(&bundle->dev);
}
spin_unlock_irq(&gb_bundles_lock);
}
int gb_bundle_init(struct gb_interface *intf, u8 bundle_id, u8 device_id)