redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

gpio: Remove VLA from MAX3191X driver 

The new challenge is to remove VLAs from the kernel
(see https://lkml.org/lkml/2018/3/7/621)

This patch replaces several a VLA with an appropriate call to
kmalloc_array.

Signed-off-by: Laura Abbott <labbott@redhat.com>
Reviewed-and-tested-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
hifive-unleashed-5.1
Laura Abbott 2018-03-09 16:10:19 -08:00 committed by Linus Walleij
parent a8ff510dbc
commit 48da181dac
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/gpio/gpio-max3191x.c
View File

@ -315,12 +315,17 @@ static void gpiod_set_array_single_value_cansleep(unsigned int ndescs,
struct gpio_desc **desc,
int value)
{
int i, values[ndescs];
int i, *values;
values = kmalloc_array(ndescs, sizeof(*values), GFP_KERNEL);
if (!values)
return;
for (i = 0; i < ndescs; i++)
values[i] = value;
gpiod_set_array_value_cansleep(ndescs, desc, values);
kfree(values);
}
static struct gpio_descs *devm_gpiod_get_array_optional_count(