redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

firmware: clean up filesystem load exit path 

This makes the error and success paths more readable while trying to
load firmware from the filesystem.

Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Josh Boyer <jwboyer@fedoraproject.org>
Cc: David Howells <dhowells@redhat.com>
Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
hifive-unleashed-5.1
Kees Cook 2016-02-04 13:15:02 -08:00 committed by Mimi Zohar
parent 5275d194e0
commit 4b2530d819
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/base/firmware_class.c
View File

@ -361,19 +361,17 @@ static int fw_get_filesystem_firmware(struct device *device,
continue;
rc = fw_read_file_contents(file, buf);
fput(file);
if (rc)
if (rc) {
dev_warn(device, "loading %s failed with error %d\n",
path, rc);
else
break;
}
__putname(path);
if (!rc) {
continue;
}
dev_dbg(device, "direct-loading %s\n",
buf->fw_id);
fw_finish_direct_load(device, buf);
break;
}
__putname(path);
return rc;
}