redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

[media] omap3isp: Don't try to locate external subdev for mem-to-mem pipelines

Browse source 
Memory-to-memory pipelines have no external subdev, we shouldn't try to
locate one and validate its configuration. The driver currently works by
chance due to another bug that results in failure to locate the external
subdev being ignored.

This gets rid of the "omap3isp omap3isp: can't find source, failing now"
error message in the kernel log when operating on a memory-to-memory
pipeline.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
Tested-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
This commit is contained in:
Laurent Pinchart 2014-02-14 21:40:48 -03:00 committed by Mauro Carvalho Chehab
parent 8b57b9669a
commit 4b2f1ed15e
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/media/platform/omap3isp/ispvideo.c
View file

@ -888,6 +888,10 @@ static int isp_video_check_external_subdevs(struct isp_video *video,
unsigned int i;
int ret = 0;
/* Memory-to-memory pipelines have no external subdev. */
if (pipe->input != NULL)
return 0;
for (i = 0; i < ARRAY_SIZE(ents); i++) {
/* Is the entity part of the pipeline? */
if (!(pipe->entities & (1 << ents[i]->id)))