redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

dm snapshot: lock snapshot while supplying status

Browse source 
This patch locks the snapshot when returning status.  It fixes a race
when it could return an invalid number of free chunks if someone
was simultaneously modifying it.

Cc: stable@kernel.org
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
This commit is contained in:
Mikulas Patocka 2009-10-16 23:18:16 +01:00 committed by Alasdair G Kergon
parent 0e8c4e4e3e
commit 4c6fff445d
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/md/dm-snap.c
View file

@ -1152,6 +1152,8 @@ static int snapshot_status(struct dm_target *ti, status_type_t type,
unsigned sz = 0;
struct dm_snapshot *snap = ti->private;
down_write(&snap->lock);
switch (type) {
case STATUSTYPE_INFO:
if (!snap->valid)
@ -1183,6 +1185,8 @@ static int snapshot_status(struct dm_target *ti, status_type_t type,
break;
}
up_write(&snap->lock);
return 0;
}