redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

USB: skeleton: Correct use of ! and & 

Correct priority problem in the use of ! and &.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@ expression E; constant C; @@
- !E & C
+ !(E & C)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
hifive-unleashed-5.1
Julia Lawall 2009-09-19 09:13:43 +02:00 committed by Greg Kroah-Hartman
parent f0ad073f04
commit 4de8405759
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/usb-skeleton.c
View File

@ -358,7 +358,7 @@ retry:
rv = skel_do_read_io(dev, count);
if (rv < 0)
goto exit;
else if (!file->f_flags & O_NONBLOCK)
else if (!(file->f_flags & O_NONBLOCK))
goto retry;
rv = -EAGAIN;
}
@ -411,7 +411,7 @@ static ssize_t skel_write(struct file *file, const char *user_buffer,
* limit the number of URBs in flight to stop a user from using up all
* RAM
*/
if (!file->f_flags & O_NONBLOCK) {
if (!(file->f_flags & O_NONBLOCK)) {
if (down_interruptible(&dev->limit_sem)) {
retval = -ERESTARTSYS;
goto exit;