redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

greybus: connection: fix connection initialisation 

Make sure connection is fully initialised before registering the
connection device and adding it to the host-device and bundle lists.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Tested-by: Rui Miguel Silva <rui.silva@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
hifive-unleashed-5.1
Johan Hovold 2015-07-22 17:49:19 +02:00 committed by Greg Kroah-Hartman
parent a4e08469eb
commit 4e2b1e46ab
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/greybus/connection.c
View File

@ -183,6 +183,10 @@ gb_connection_create_range(struct greybus_host_device *hd,
connection->bundle = bundle;
connection->state = GB_CONNECTION_STATE_DISABLED;
atomic_set(&connection->op_cycle, 0);
spin_lock_init(&connection->lock);
INIT_LIST_HEAD(&connection->operations);
connection->dev.parent = parent;
connection->dev.bus = &greybus_bus_type;
connection->dev.type = &greybus_connection_type;
@ -215,10 +219,6 @@ gb_connection_create_range(struct greybus_host_device *hd,
spin_unlock_irq(&gb_connections_lock);
atomic_set(&connection->op_cycle, 0);
spin_lock_init(&connection->lock);
INIT_LIST_HEAD(&connection->operations);
/* XXX Will have to establish connections to get version */
gb_connection_bind_protocol(connection);
if (!connection->protocol)