redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

IB/rxe: avoid back-to-back retries

Browse source 
Error retries can occur due to timeouts, NAKs or receiving
packets beyond the current read request. Avoid back-to-back
retries due to packet processing, by only retrying the initial
attempt immediately. Subsequent retries must be due to timeouts.

Continue to process completion packets after scheduling a retry.

Signed-off-by: Vijay Immanuel <vijayi@attalasystems.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
This commit is contained in:
Vijay Immanuel 2018-06-13 18:47:30 -07:00 committed by Doug Ledford
parent b97db58557
commit 4e4c53df56
2 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
drivers/infiniband/sw/rxe/rxe_comp.c
View file

@ -191,6 +191,7 @@ static inline void reset_retry_counters(struct rxe_qp *qp)
{
qp->comp.retry_cnt = qp->attr.retry_cnt;
qp->comp.rnr_retry = qp->attr.rnr_retry;
qp->comp.started_retry = 0;
}
static inline enum comp_state check_psn(struct rxe_qp *qp,
@ -676,6 +677,20 @@ int rxe_completer(void *arg)
goto exit;
}
/* if we've started a retry, don't start another
* retry sequence, unless this is a timeout.
*/
if (qp->comp.started_retry &&
!qp->comp.timeout_retry) {
if (pkt) {
rxe_drop_ref(pkt->qp);
kfree_skb(skb);
skb = NULL;
}
goto done;
}
if (qp->comp.retry_cnt > 0) {
if (qp->comp.retry_cnt != 7)
qp->comp.retry_cnt--;
@ -692,6 +707,7 @@ int rxe_completer(void *arg)
rxe_counter_inc(rxe,
RXE_CNT_COMP_RETRY);
qp->req.need_retry = 1;
qp->comp.started_retry = 1;
rxe_run_task(&qp->req.task, 1);
}
@ -701,7 +717,7 @@ int rxe_completer(void *arg)
skb = NULL;
}
goto exit;
goto done;
} else {
rxe_counter_inc(rxe, RXE_CNT_RETRY_EXCEEDED);

1
drivers/infiniband/sw/rxe/rxe_verbs.h
View file

@ -158,6 +158,7 @@ struct rxe_comp_info {
int opcode;
int timeout;
int timeout_retry;
int started_retry;
u32 retry_cnt;
u32 rnr_retry;
struct rxe_task task;