redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

net: usb: asix_devices: fix missing return code check on call to asix_write_medium_mode 

The call to asix_write_medium_mode is not updating the return code ret
and yet ret is being checked for an error. Fix this by assigning ret to
the return code from the call asix_write_medium_mode.

Detected by CoverityScan, CID#1357148 ("Logically Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hifive-unleashed-5.1
Colin Ian King 2017-02-28 11:58:22 +00:00 committed by David S. Miller
parent 0bf09c397e
commit 4f3de46f7a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/usb/asix_devices.c
View File

@ -346,7 +346,7 @@ static int ax88772_reset(struct usbnet *dev)
if (ret < 0)
goto out;
asix_write_medium_mode(dev, AX88772_MEDIUM_DEFAULT, 0);
ret = asix_write_medium_mode(dev, AX88772_MEDIUM_DEFAULT, 0);
if (ret < 0)
goto out;