redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

net: phy: marvell: Checkpatch - assignments and comparisons 

Avoid multiple assignments
Comparisons should place the constant on the right side of the test

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
hifive-unleashed-5.1
Andrew Lunn 2017-05-17 03:26:01 +02:00 committed by David S. Miller
parent e69d9ed4fa
commit 4f48ed32fb
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/phy/marvell.c
View File

@ -1101,7 +1101,7 @@ static int marvell_read_status_page(struct phy_device *phydev, int page)
if (err)
return err;
if (AUTONEG_ENABLE == phydev->autoneg) {
if (phydev->autoneg == AUTONEG_ENABLE) {
status = phy_read(phydev, MII_M1011_PHY_STATUS);
if (status < 0)
return status;
@ -1126,7 +1126,8 @@ static int marvell_read_status_page(struct phy_device *phydev, int page)
phydev->duplex = DUPLEX_HALF;
status = status & MII_M1011_PHY_STATUS_SPD_MASK;
phydev->pause = phydev->asym_pause = 0;
phydev->pause = 0;
phydev->asym_pause = 0;
switch (status) {
case MII_M1011_PHY_STATUS_1000:
@ -1185,7 +1186,8 @@ static int marvell_read_status_page(struct phy_device *phydev, int page)
else
phydev->speed = SPEED_10;
phydev->pause = phydev->asym_pause = 0;
phydev->pause = 0;
phydev->asym_pause = 0;
phydev->lp_advertising = 0;
}