redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

gpio: Fix return value check in xgene_gpio_probe() 

In case of error, the function devm_ioremap_nocache() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
hifive-unleashed-5.1
Wei Yongjun 2014-09-12 07:12:14 +08:00 committed by Linus Walleij
parent 43a8785aee
commit 4f51b91335
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpio/gpio-xgene.c
View File

@ -182,8 +182,8 @@ static int xgene_gpio_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
gpio->base = devm_ioremap_nocache(&pdev->dev, res->start,
resource_size(res));
if (IS_ERR(gpio->base)) {
err = PTR_ERR(gpio->base);
if (!gpio->base) {
err = -ENOMEM;
goto err;
}