redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

greybus: interface: hibernate UniPro link in activation error path 

To be well-behaved, we should hibernate the link before disabling UniPro
in case the link has already been established (i.e. when the interface
type has been detected as UniPro or Greybus).

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Sandeep Patil <sspatil@google.com>
Reviewed-by: Patrick Titiano <ptitiano@baylibre.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
hifive-unleashed-5.1
Johan Hovold 2016-07-20 16:40:27 +02:00 committed by Greg Kroah-Hartman
parent e21e6bad3f
commit 4f7e413b2d
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/staging/greybus/interface.c
View File

@ -947,8 +947,15 @@ static int _gb_interface_activate(struct gb_interface *intf,
goto err_refclk_disable;
ret = gb_interface_activate_operation(intf, type);
if (ret)
goto err_unipro_disable;
if (ret) {
switch (*type) {
case GB_INTERFACE_TYPE_UNIPRO:
case GB_INTERFACE_TYPE_GREYBUS:
goto err_hibernate_link;
default:
goto err_unipro_disable;
}
}
ret = gb_interface_read_dme(intf);
if (ret)