redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

ASoC: imx-sgtl5000: Fix uninitialized pointer use in error path 

This patch avoids to dereference the uninitialized data pointer if the
error path is entered before devm_kzalloc is called (or if the allocation
fails). It fixes the following warning:

    sound/soc/fsl/imx-sgtl5000.c: In function 'imx_sgtl5000_probe':
    sound/soc/fsl/imx-sgtl5000.c:175:18: warning: 'data' may be used uninitialized in this function [-Wmaybe-uninitialized]

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
hifive-unleashed-5.1
Philipp Zabel 2013-09-25 15:22:01 +02:00 committed by Mark Brown
parent a8b22c1ccc
commit 50d4a790e6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sound/soc/fsl/imx-sgtl5000.c
View File

@ -62,7 +62,7 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
struct device_node *ssi_np, *codec_np;
struct platform_device *ssi_pdev;
struct i2c_client *codec_dev;
struct imx_sgtl5000_data *data;
struct imx_sgtl5000_data *data = NULL;
int int_port, ext_port;
int ret;
@ -172,7 +172,7 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
return 0;
fail:
if (!IS_ERR(data->codec_clk))
if (data && !IS_ERR(data->codec_clk))
clk_put(data->codec_clk);
if (ssi_np)
of_node_put(ssi_np);