redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

lightnvm: fix possible memory leak in pblk_bb_discovery() 

'blks' is malloced in pblk_bb_discovery() and should be freed
before leaving from the nvm_get_tgt_bb_tbl() error handling cases,
otherwise it will cause memory leak. Also skip assign blks to
rlun->bb_list when error.

Fixes: a4bd217b43 ("lightnvm: physical block device (pblk) target")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Javier González <javier@cnexlabs.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
hifive-unleashed-5.1
Wei Yongjun 2017-04-25 16:15:30 +00:00 committed by Jens Axboe
parent 543b334d14
commit 5136a4fd58
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/lightnvm/pblk-init.c
View File

@ -399,13 +399,15 @@ static int pblk_bb_discovery(struct nvm_tgt_dev *dev, struct pblk_lun *rlun)
nr_blks = nvm_bb_tbl_fold(dev->parent, blks, nr_blks);
if (nr_blks < 0) {
kfree(blks);
ret = nr_blks;
goto out;
}
rlun->bb_list = blks;
return 0;
out:
kfree(blks);
return ret;
}