redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

[ALSA] missing error check in usb sound driver 

usb_set_interface() can fail, even for altsetting 0

Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz>
hifive-unleashed-5.1
Oliver Neukum 2007-08-31 12:15:27 +02:00 committed by Jaroslav Kysela
parent 15944806e2
commit 5149fe2c15
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sound/usb/usbaudio.c
View File

@ -1308,7 +1308,11 @@ static int set_format(struct snd_usb_substream *subs, struct audioformat *fmt)
/* close the old interface */
if (subs->interface >= 0 && subs->interface != fmt->iface) {
usb_set_interface(subs->dev, subs->interface, 0);
if (usb_set_interface(subs->dev, subs->interface, 0) < 0) {
snd_printk(KERN_ERR "%d:%d:%d: return to setting 0 failed\n",
dev->devnum, fmt->iface, fmt->altsetting);
return -EIO;
}
subs->interface = -1;
subs->format = 0;
}