redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

greybus: interface: name routines consistently

Browse source 
Routines should be named this way: gb_<object>_<operation>. Fix all
routines that don't match this.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Viresh Kumar 2015-05-20 17:33:51 +05:30 committed by Greg Kroah-Hartman
parent 5ddf738e94
commit 51b5d8d783
4 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/staging/greybus/ap.c
View file

@ -175,7 +175,7 @@ static void svc_hotplug(struct svc_function_hotplug *hotplug,
return; return;
} }
dev_dbg(hd->parent, "interface id %d added\n", interface_id); dev_dbg(hd->parent, "interface id %d added\n", interface_id);
gb_add_interface(hd, interface_id, hotplug->data, gb_interface_add(hd, interface_id, hotplug->data,
payload_length - 0x02); payload_length - 0x02);
break; break;
@ -189,7 +189,7 @@ static void svc_hotplug(struct svc_function_hotplug *hotplug,
return; return;
} }
dev_dbg(hd->parent, "interface id %d removed\n", interface_id); dev_dbg(hd->parent, "interface id %d removed\n", interface_id);
gb_remove_interface(hd, interface_id); gb_interface_remove(hd, interface_id);
break; break;
default: default:

2
drivers/staging/greybus/core.c
View file

@ -215,7 +215,7 @@ void greybus_remove_hd(struct greybus_host_device *hd)
* with this host controller before freeing the memory associated with * with this host controller before freeing the memory associated with
* the host controller. * the host controller.
*/ */
gb_remove_interfaces(hd); gb_interfaces_remove(hd);
gb_endo_remove(hd->endo); gb_endo_remove(hd->endo);
kref_put_mutex(&hd->kref, free_hd, &hd_mutex); kref_put_mutex(&hd->kref, free_hd, &hd_mutex);
} }

12
drivers/staging/greybus/interface.c
View file

@ -54,7 +54,7 @@ struct gb_interface *gb_interface_find(struct greybus_host_device *hd,
return NULL; return NULL;
} }
static void greybus_interface_release(struct device *dev) static void gb_interface_release(struct device *dev)
{ {
struct gb_interface *intf = to_gb_interface(dev); struct gb_interface *intf = to_gb_interface(dev);
@ -63,7 +63,7 @@ static void greybus_interface_release(struct device *dev)
struct device_type greybus_interface_type = { struct device_type greybus_interface_type = {
.name = "greybus_interface", .name = "greybus_interface",
.release = greybus_interface_release, .release = gb_interface_release,
}; };
/* /*
@ -161,12 +161,12 @@ static void gb_interface_destroy(struct gb_interface *intf)
} }
/** /**
* gb_add_interface * gb_interface_add
* *
* Pass in a buffer that _should_ contain a Greybus manifest * Pass in a buffer that _should_ contain a Greybus manifest
* and register a greybus device structure with the kernel core. * and register a greybus device structure with the kernel core.
*/ */
void gb_add_interface(struct greybus_host_device *hd, u8 interface_id, u8 *data, void gb_interface_add(struct greybus_host_device *hd, u8 interface_id, u8 *data,
int size) int size)
{ {
struct gb_interface *intf; struct gb_interface *intf;
@ -201,7 +201,7 @@ err_parse:
gb_interface_destroy(intf); gb_interface_destroy(intf);
} }
void gb_remove_interface(struct greybus_host_device *hd, u8 interface_id) void gb_interface_remove(struct greybus_host_device *hd, u8 interface_id)
{ {
struct gb_interface *intf = gb_interface_find(hd, interface_id); struct gb_interface *intf = gb_interface_find(hd, interface_id);
@ -212,7 +212,7 @@ void gb_remove_interface(struct greybus_host_device *hd, u8 interface_id)
interface_id); interface_id);
} }
void gb_remove_interfaces(struct greybus_host_device *hd) void gb_interfaces_remove(struct greybus_host_device *hd)
{ {
struct gb_interface *intf, *temp; struct gb_interface *intf, *temp;

6
drivers/staging/greybus/interface.h
View file

@ -47,10 +47,10 @@ static inline void *gb_interface_get_drvdata(struct gb_interface *intf)
struct gb_interface *gb_interface_find(struct greybus_host_device *hd, struct gb_interface *gb_interface_find(struct greybus_host_device *hd,
u8 interface_id); u8 interface_id);
void gb_add_interface(struct greybus_host_device *hd, u8 interface_id, u8 *data, void gb_interface_add(struct greybus_host_device *hd, u8 interface_id, u8 *data,
int size); int size);
void gb_remove_interface(struct greybus_host_device *hd, u8 interface_id); void gb_interface_remove(struct greybus_host_device *hd, u8 interface_id);
void gb_remove_interfaces(struct greybus_host_device *hd); void gb_interfaces_remove(struct greybus_host_device *hd);
#endif /* __INTERFACE_H */ #endif /* __INTERFACE_H */