redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

fuse: fix fuse_file_lseek returning with lock held 

This bug was found with smatch (http://repo.or.cz/w/smatch.git/).  If
we return directly the inode->i_mutex lock doesn't get released.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
CC: stable@kernel.org
hifive-unleashed-5.1
Dan Carpenter 2009-03-27 13:36:10 +03:00 committed by Miklos Szeredi
parent 0d34fb8e93
commit 5291658d87
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/fuse/file.c
View File

@ -1465,7 +1465,7 @@ static loff_t fuse_file_llseek(struct file *file, loff_t offset, int origin)
case SEEK_END:
retval = fuse_update_attributes(inode, NULL, file, NULL);
if (retval)
return retval;
goto exit;
offset += i_size_read(inode);
break;
case SEEK_CUR:
@ -1479,6 +1479,7 @@ static loff_t fuse_file_llseek(struct file *file, loff_t offset, int origin)
}
retval = offset;
}
exit:
mutex_unlock(&inode->i_mutex);
return retval;
}