redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

greybus: connection: Return bool from gb_connection_intf_find() 

This is used only to check if an existing connection already uses the
cport_id or not and doesn't really need to return pointer to the
connection.

While at it, also rename it to suit its purpose.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
hifive-unleashed-5.1
Viresh Kumar 2016-06-10 14:59:09 +05:30 committed by Greg Kroah-Hartman
parent 60fb3405c7
commit 54131222e6
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/staging/greybus/connection.c
View File

@ -21,8 +21,7 @@ static DEFINE_MUTEX(gb_connection_mutex);
/* Caller holds gb_connection_mutex. */
static struct gb_connection *
gb_connection_intf_find(struct gb_interface *intf, u16 cport_id)
static bool gb_connection_cport_in_use(struct gb_interface *intf, u16 cport_id)
{
struct gb_host_device *hd = intf->hd;
struct gb_connection *connection;
@ -30,10 +29,10 @@ gb_connection_intf_find(struct gb_interface *intf, u16 cport_id)
list_for_each_entry(connection, &hd->connections, hd_links) {
if (connection->intf == intf &&
connection->intf_cport_id == cport_id)
return connection;
return true;
}
return NULL;
return false;
}
static void gb_connection_get(struct gb_connection *connection)
@ -155,7 +154,7 @@ _gb_connection_create(struct gb_host_device *hd, int hd_cport_id,
mutex_lock(&gb_connection_mutex);
if (intf && gb_connection_intf_find(intf, cport_id)) {
if (intf && gb_connection_cport_in_use(intf, cport_id)) {
dev_err(&intf->dev, "cport %u already in use\n", cport_id);
ret = -EBUSY;
goto err_unlock;