redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

ASoC: soc-core: rename soc_post_component_init() to soc_rtd_init() 

It is easy to read code if it is cleanly using paired function/naming,
like start <-> stop, register <-> unregister, etc, etc.
But, current ALSA SoC code is very random, unbalance, not paired, etc.
It is easy to create bug at the such code, and it will be difficult to
debug.

From function name point of view, "soc_post_component_init()" sounds
like "component initialize function".
But in reality it is rtd setup function.

This patch renames soc_post_component_init() to soc_rtd_init()

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87v9uo7lc3.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
alistair/sunxi64-5.4-dsi
Kuninori Morimoto 2019-08-23 09:58:32 +09:00 committed by Mark Brown
parent 495efdb01f
commit 542694df75
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sound/soc/soc-core.c
View File

@ -1340,13 +1340,12 @@ err_probe:
return ret;
}
static void rtd_release(struct device *dev)
static void soc_rtd_release(struct device *dev)
{
kfree(dev);
}
static int soc_post_component_init(struct snd_soc_pcm_runtime *rtd,
const char *name)
static int soc_rtd_init(struct snd_soc_pcm_runtime *rtd, const char *name)
{
int ret = 0;
@ -1355,7 +1354,7 @@ static int soc_post_component_init(struct snd_soc_pcm_runtime *rtd,
if (!rtd->dev)
return -ENOMEM;
rtd->dev->parent = rtd->card->dev;
rtd->dev->release = rtd_release;
rtd->dev->release = soc_rtd_release;
rtd->dev->groups = soc_dev_attr_groups;
dev_set_name(rtd->dev, "%s", name);
dev_set_drvdata(rtd->dev, rtd);
@ -1483,7 +1482,7 @@ static int soc_probe_link_dais(struct snd_soc_card *card,
return ret;
}
ret = soc_post_component_init(rtd, dai_link->name);
ret = soc_rtd_init(rtd, dai_link->name);
if (ret)
return ret;