pinctrl: digicolor: make it explicitly non-modular
The Kconfig currently controlling compilation of this code is: drivers/pinctrl/Kconfig:config PINCTRL_DIGICOLOR drivers/pinctrl/Kconfig: bool ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. We explicitly disallow a driver unbind, since that doesn't have a sensible use case anyway, and it allows us to drop the ".remove" code for non-modular drivers. Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit. Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. Cc: linux-gpio@vger.kernel.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Acked-by: Baruch Siach <baruch@tkos.co.il> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
parent
4c3deee95f
commit
546c6d7930
|
@ -15,7 +15,7 @@
|
||||||
* - Pin pad configuration (pull up/down, strength)
|
* - Pin pad configuration (pull up/down, strength)
|
||||||
*/
|
*/
|
||||||
|
|
||||||
#include <linux/module.h>
|
#include <linux/init.h>
|
||||||
#include <linux/platform_device.h>
|
#include <linux/platform_device.h>
|
||||||
#include <linux/of.h>
|
#include <linux/of.h>
|
||||||
#include <linux/of_device.h>
|
#include <linux/of_device.h>
|
||||||
|
@ -337,27 +337,17 @@ static int dc_pinctrl_probe(struct platform_device *pdev)
|
||||||
return dc_gpiochip_add(pmap, pdev->dev.of_node);
|
return dc_gpiochip_add(pmap, pdev->dev.of_node);
|
||||||
}
|
}
|
||||||
|
|
||||||
static int dc_pinctrl_remove(struct platform_device *pdev)
|
|
||||||
{
|
|
||||||
struct dc_pinmap *pmap = platform_get_drvdata(pdev);
|
|
||||||
|
|
||||||
gpiochip_remove(&pmap->chip);
|
|
||||||
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
static const struct of_device_id dc_pinctrl_ids[] = {
|
static const struct of_device_id dc_pinctrl_ids[] = {
|
||||||
{ .compatible = "cnxt,cx92755-pinctrl" },
|
{ .compatible = "cnxt,cx92755-pinctrl" },
|
||||||
{ /* sentinel */ }
|
{ /* sentinel */ }
|
||||||
};
|
};
|
||||||
MODULE_DEVICE_TABLE(of, dc_pinctrl_ids);
|
|
||||||
|
|
||||||
static struct platform_driver dc_pinctrl_driver = {
|
static struct platform_driver dc_pinctrl_driver = {
|
||||||
.driver = {
|
.driver = {
|
||||||
.name = DRIVER_NAME,
|
.name = DRIVER_NAME,
|
||||||
.of_match_table = dc_pinctrl_ids,
|
.of_match_table = dc_pinctrl_ids,
|
||||||
|
.suppress_bind_attrs = true,
|
||||||
},
|
},
|
||||||
.probe = dc_pinctrl_probe,
|
.probe = dc_pinctrl_probe,
|
||||||
.remove = dc_pinctrl_remove,
|
|
||||||
};
|
};
|
||||||
module_platform_driver(dc_pinctrl_driver);
|
builtin_platform_driver(dc_pinctrl_driver);
|
||||||
|
|
Loading…
Reference in a new issue