redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

md/raid10: remove unnecessary smp_mb() from end_sync_write 

Recent commit 4ca40c2ce0 (md/raid10: Allow replacement device ...)
added an smp_mb in end_sync_write.
This was to close a possible race with raid10_remove_disk.
However there is no such race as it is never attempted to remove a
disk while resync (or recovery) is happening.
so the smp_mb is just noise.

Signed-off-by: NeilBrown <neilb@suse.de>
hifive-unleashed-5.1
NeilBrown 2012-03-13 11:21:20 +11:00
parent 1e3fa9bd50
commit 547414d19f
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/md/raid10.c
View File

@ -1682,10 +1682,8 @@ static void end_sync_write(struct bio *bio, int error)
d = find_bio_disk(conf, r10_bio, bio, &slot, &repl);
if (repl)
rdev = conf->mirrors[d].replacement;
if (!rdev) {
smp_mb();
else
rdev = conf->mirrors[d].rdev;
}
if (!uptodate) {
if (repl)