redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

sctp: use list_move_tail instead of list_del/list_add_tail 

Using list_move_tail() instead of list_del() + list_add_tail().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
hifive-unleashed-5.1
Wei Yongjun 2012-09-03 23:58:16 +00:00 committed by David S. Miller
parent 6e129d04de
commit 54a2792423
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
net/sctp/outqueue.c
View File

@ -591,9 +591,8 @@ static int sctp_outq_flush_rtx(struct sctp_outq *q, struct sctp_packet *pkt,
* next chunk.
*/
if (chunk->tsn_gap_acked) {
list_del(&chunk->transmitted_list);
list_add_tail(&chunk->transmitted_list,
&transport->transmitted);
list_move_tail(&chunk->transmitted_list,
&transport->transmitted);
continue;
}
@ -657,9 +656,8 @@ redo:
/* The append was successful, so add this chunk to
* the transmitted list.
*/
list_del(&chunk->transmitted_list);
list_add_tail(&chunk->transmitted_list,
&transport->transmitted);
list_move_tail(&chunk->transmitted_list,
&transport->transmitted);
/* Mark the chunk as ineligible for fast retransmit
* after it is retransmitted.