redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

drivers/sbus/char: Micro-optimization in display7seg.c 

Flipping a bit doesn't need four lines of code; and gcc seems to
actually generate two branches.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
hifive-unleashed-5.1
Rasmus Villemoes 2014-06-19 14:31:52 +02:00 committed by David S. Miller
parent 57a4a3d7f7
commit 54dcf0ceb8
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/sbus/char/display7seg.c
View File

@ -144,10 +144,7 @@ static long d7s_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
case D7SIOCTM:
/* toggle device mode-- flip display orientation */
if (regs & D7S_FLIP)
regs &= ~D7S_FLIP;
else
regs |= D7S_FLIP;
regs ^= D7S_FLIP;
writeb(regs, p->regs);
break;
}