redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

media: imx7-media-csi: Use devm_platform_ioremap_resource()

Browse source 
Use devm_platform_ioremap_resource() to simplify the code a bit.

While at it, propagate the real error value in case of
devm_platform_ioremap_resource() failure.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
Tested-by: Rui Miguel Silva <rmfrfs@gmail.com>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Fabio Estevam 2019-05-04 10:40:21 -04:00 committed by Mauro Carvalho Chehab
parent 434d40df05
commit 55be6fd274
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/staging/media/imx/imx7-media-csi.c
View file

@ -1164,7 +1164,6 @@ static int imx7_csi_probe(struct platform_device *pdev)
struct device_node *node = dev->of_node;
struct imx_media_dev *imxmd;
struct imx7_csi *csi;
struct resource *res;
int ret;
csi = devm_kzalloc(&pdev->dev, sizeof(*csi), GFP_KERNEL);
@ -1180,17 +1179,16 @@ static int imx7_csi_probe(struct platform_device *pdev)
return ret;
}
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
csi->irq = platform_get_irq(pdev, 0);
if (!res || csi->irq < 0) {
if (csi->irq < 0) {
dev_err(dev, "Missing platform resources data\n");
return -ENODEV;
}
csi->regbase = devm_ioremap_resource(dev, res);
csi->regbase = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(csi->regbase)) {
dev_err(dev, "Failed platform resources map\n");
return -ENODEV;
return PTR_ERR(csi->regbase);
}
spin_lock_init(&csi->irqlock);