Staging: panel: fix oops on panel_cleanup_module
Check for null pardevice (not registered, ej: panel never attached, inexistent parport, etc. ) before calling parport_release, parport_unregister_device, and related funcs on module release. Signed-off-by: Costantino Leandro <lcostantino@gmail.com> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>hifive-unleashed-5.1
parent
096c55d1de
commit
5789813e73
|
@ -2164,19 +2164,20 @@ static void __exit panel_cleanup_module(void)
|
||||||
if (scan_timer.function != NULL)
|
if (scan_timer.function != NULL)
|
||||||
del_timer(&scan_timer);
|
del_timer(&scan_timer);
|
||||||
|
|
||||||
if (keypad_enabled)
|
if (pprt != NULL) {
|
||||||
misc_deregister(&keypad_dev);
|
if (keypad_enabled)
|
||||||
|
misc_deregister(&keypad_dev);
|
||||||
|
|
||||||
if (lcd_enabled) {
|
if (lcd_enabled) {
|
||||||
panel_lcd_print("\x0cLCD driver " PANEL_VERSION
|
panel_lcd_print("\x0cLCD driver " PANEL_VERSION
|
||||||
"\nunloaded.\x1b[Lc\x1b[Lb\x1b[L-");
|
"\nunloaded.\x1b[Lc\x1b[Lb\x1b[L-");
|
||||||
misc_deregister(&lcd_dev);
|
misc_deregister(&lcd_dev);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* TODO: free all input signals */
|
||||||
|
parport_release(pprt);
|
||||||
|
parport_unregister_device(pprt);
|
||||||
}
|
}
|
||||||
|
|
||||||
/* TODO: free all input signals */
|
|
||||||
|
|
||||||
parport_release(pprt);
|
|
||||||
parport_unregister_device(pprt);
|
|
||||||
parport_unregister_driver(&panel_driver);
|
parport_unregister_driver(&panel_driver);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue