redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

spi: orion: Fix return value check in orion_spi_probe() 

In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mark Brown <broonie@kernel.org>
hifive-unleashed-5.1
Wei Yongjun 2016-06-13 14:32:23 +00:00 committed by Mark Brown
parent b3c195b3a7
commit 57c624ae1c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/spi/spi-orion.c
View File

@ -655,8 +655,8 @@ static int orion_spi_probe(struct platform_device *pdev)
spi->direct_access[cs].vaddr = devm_ioremap(&pdev->dev,
r->start,
PAGE_SIZE);
if (IS_ERR(spi->direct_access[cs].vaddr)) {
status = PTR_ERR(spi->direct_access[cs].vaddr);
if (!spi->direct_access[cs].vaddr) {
status = -ENOMEM;
goto out_rel_clk;
}
spi->direct_access[cs].size = PAGE_SIZE;